feat(lsp): Implement textDocument/rename #8910
Conversation
|
|
cli/lsp/tsc.rs
Outdated
| impl RenameLocations { | ||
| pub async fn into_workspace_edit( | ||
| self, | ||
| ls: &LanguageServer, |
There was a problem hiding this comment.
The RenameLocations can have the locations that is not same to current document so we should accept LanguageServer to resolve line_index per each locations.
There was a problem hiding this comment.
I think you should be able to use the same approach as DefinitionInfoAndBoundSpan::to_definition. The index_provider argument there is probably what you want.
There was a problem hiding this comment.
Thank you! I'll fix it.
There was a problem hiding this comment.
I fixed it with referencing DefinitionInfoAndBoundSpan::to_definition.
It will never support it, so the resulting behaviour is the desired behaviour. |
Related #8643
Currently, the ConfigureRequest (in
cli/tsc/compiler.d.ts) does not supporttsconfig.json'sinclude/excludefield.So the tsserver will rename symbols in only the opened text document or explicitly dependent text document.